-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes carlarc's OP chocolate #6003
Conversation
The whole gimmick of chunk box is it having fun amount of damage, which is a reference to its historical real life counterpart, here you just kill the whole reference joke (without even editing the item description) despite having ability to just set low attack speed, or make it so the chunk box breaks (deletes) after being used a weapon a few times, or you just could've been more smart about it and ported this instead, which'd solve any possible similar problems in the future forever, also your pr doesn't even fix the referenced issue to begin with. |
Obviously I'll wait for maintainer input on the pr, but a few things |
Ok, took a closer look into the codebase and the attack speed is too variable to make it consistent between a few defines. It would essentially be a balance change which is not ideal for a bug fix. I'll go ahead and port the tg implementation. |
So for the maintainers to catch up, there was a discussion on discord. Turns out the whole meme of the chunk box being a weapon is in-itself a meme because you can't even hit mobs with it; the chunk box now has a demolition modifier making it pretty much useless against structures but an effective melee weapon and the attack speed was lowered significantly. |
Co-authored-by: Vicacrov <[email protected]>
Co-authored-by: Vicacrov <[email protected]>
Co-authored-by: Vicacrov <[email protected]>
Co-authored-by: SabreML <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more things
Co-authored-by: SabreML <[email protected]>
Co-authored-by: SabreML <[email protected]>
Co-authored-by: SabreML <[email protected]>
About the pull request
Fixes #4695, The issue isn't inherently the attack speed, although it is quite fast, many small items also have a relatively fast attack speed. The problem is that when you combine the attack speed with a food item that somehow has a force of 35 you get a very effective weapon capable of destroying many different types of structures fairly easily, same issue with the scalpel.
My solution here was to just decrease the amount of force the items have rather than lowering the attack speed. You shouldn't be able to use a scalpel or a box of chocolate to more effectively destroy weeds rather than a machete. I doubt these are the only two items that have this problem, I guess in the future when someone comes across a similar issue just link this pr so they can easily identify the exploit.
Changelog
🆑
fix: lowers the scalpel and chunk box's ability to destroy various structures.
add: chunk box is now a melee weapon
/:cl: